Refactor for f strings.#984
Conversation
changeling
force-pushed
the
refactor-for-f-strings-
branch
5 times, most recently
from
feb1c0c to
9811ddd
Compare
|
Your |
|
Also please rebase from |
changeling
force-pushed
the
refactor-for-f-strings-
branch
from
9811ddd to
683cfa3
Compare
ekampf
left a comment
ekampf
left a comment
There was a problem hiding this comment.
Per our discussion on slack, lets use this opportunity to consistently use either
f"{repr(value)} or f"{value!r}".
We decided on repr in Slack...
changeling
force-pushed
the
refactor-for-f-strings-
branch
2 times, most recently
from
ea6c9b2 to
f7d1688
Compare
|
F-Strings are not supported in Python 2.7, so this PR would need to be merged in 3.0 when 2.7 and 3.4 support is dropped. Making sure this is tagged appropriately. |
Good note, and thanks. I'd not thought to do that, as it's targeted at |
…kened project. Rebased to trigger ci. Blackened project, due to Travis failures. f-string formatting where applicable. Minor corrections to language. Corrected typo, missing parens. Update test_structures.py to match updated phrasing. Bowing to the wisdom of black. As per black, adjusted line length in types/argument.py (line 67). One more kick in the pants by black. More f-strings. More blackening.
changeling
force-pushed
the
refactor-for-f-strings-
branch
from
f7d1688 to
a432239
Compare
@ekampf, "View changes" doesn't offer changes, so I'm unable to mark this change request as resolved. |
jkimbo
left a comment
jkimbo
left a comment
There was a problem hiding this comment.
👍 looks good. Minor suggestions but they don't block merge.
|
This is gonna need to wait until we decide on 3.5 support. |
|
Lookd like we have concensus on 3.6+, so this is ready to go (or review more)! |
|
What's the status here? Requested changes made, though the system still shows Can this be merged/reviewed so I can clear this from my end or address any new changes? @ProjectCheshire? |
|
Thoughts on reviewing/merging this, @ProjectCheshire, @ekampf, @dan98765 ? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Any updates on this PR? Just curious as the author has no activity since July 2019 😨 |
|
@KingDarBoja its kind of stuck on conflicts it seem... @changeling ? |
|
Apologizes for the delay actioning this PR. This PR is taking the next steps to replace f-strings: #1158 |
* Updated all str.format(…) to f-strings This revamps the PR #984 * Pass black * Fix flake8 * Updated objecttype * Fix black version
6 participants
Left the ``deprecated.py` alone for now, but it perhaps that deserves re-factoring for a very minor performance win?
Skipping some of
relay/tests/test_connection_query.pyfor nested quoting laziness on my part.